Bump max cpus per VM to 254 (#2974)

* bump max cpus per VM to 254

* make that 128

Author: david-crespo

app/api/util.ts

@@ -24,14 +24,17 @@ import type {
   VpcFirewallRuleUpdate,
 } from './__generated__/Api'
 
-// API limits encoded in https://github.com/oxidecomputer/omicron/blob/aec3cd8d/nexus/src/app/mod.rs
+// API limits encoded in https://github.com/oxidecomputer/omicron/blob/44e65c3/nexus/src/app/mod.rs#L130-L161
 
 // These are not actually used in app code, just the mock server. In the app we
 // can rely on API errors to communicate these limits.
 export const MAX_NICS_PER_INSTANCE = 8
 export const MAX_DISKS_PER_INSTANCE = 12
 
-export const INSTANCE_MAX_CPU = 64
+// Limit is 254 on the backend but we haven't shipped any hardware that supports
+// that, so let's do 128 for now
+export const INSTANCE_MAX_CPU = 128
+
 export const INSTANCE_MIN_RAM_GiB = 1
 export const INSTANCE_MAX_RAM_GiB = 1536
 

test/e2e/instance-create.e2e.ts

@@ -665,7 +665,7 @@ test('Validate CPU and RAM', async ({ page }) => {
 
   const submitButton = page.getByRole('button', { name: 'Create instance' })
 
-  const cpuMsg = page.getByText('Can be at most 64').first()
+  const cpuMsg = page.getByText('Can be at most 128').first()
   const memMsg = page.getByText('Can be at most 1536 GiB').first()
 
   await expect(cpuMsg).toBeHidden()