Skip to content

Update firewall types #1161

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 20, 2022
Merged

Update firewall types #1161

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e005e1a
Update firewall types
zephraph Sep 19, 2022
784ddbe
Merge branch 'main' into firewall-rule-tweaks
zephraph Sep 19, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion app/forms/firewall-rules-create.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -130,6 +130,8 @@ export const CommonFields = ({ error }: { error: ErrorResult | null }) => {
{ value: 'vpc', label: 'VPC' },
{ value: 'subnet', label: 'VPC Subnet' },
{ value: 'instance', label: 'Instance' },
{ value: 'ip', label: 'IP' },
{ value: 'ipNet', label: 'IP subnet' },
]}
/>
{/* TODO: This is set as optional which is kind of wrong. This section represents an inlined
Expand Down Expand Up @@ -209,7 +211,7 @@ export const CommonFields = ({ error }: { error: ErrorResult | null }) => {
{ value: 'subnet', label: 'VPC Subnet' },
{ value: 'instance', label: 'Instance' },
{ value: 'ip', label: 'IP' },
{ value: 'internet_gateway', label: 'Internet Gateway' },
{ value: 'ipNet', label: 'IP Subnet' },
]}
/>
{/* For everything but IP this is a name, but for IP it's an IP.
Expand Down