Remove instance create hack #1249
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Contributor
Author
|
This PR is blocked by oxidecomputer/omicron#812. |
Collaborator
|
Should also do #958 |
just-be-dev
force-pushed
the
remove-instance-create-hack
branch
from
b2fd729 to
834e4b8
Compare
just-be-dev
force-pushed
the
remove-instance-create-hack
branch
from
834e4b8 to
2e86f88
Compare
just-be-dev
force-pushed
the
remove-instance-create-hack
branch
from
2e86f88 to
bb88535
Compare
Contributor
Author
|
depends on oxidecomputer/omicron#1873 |
just-be-dev
force-pushed
the
remove-instance-create-hack
branch
from
fe6a3d3 to
369b775
Compare
Collaborator
|
I think you should also change |
Contributor
Author
|
Going to land this. Happy to follow up on changes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We were hacking around the fact that disks couldn't be created on instance create. This removes the workaround in console but some work will still need to be done to ensure everything works as expected in Nexus.