Add loading state to ok button in confirm delete modal #1750
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
david-crespo
commented
Sep 5, 2023
| actionText: React.ReactNode | ||
| actionLoading?: boolean | ||
| cancelText?: string | ||
| disabled?: boolean |
Collaborator
Author
There was a problem hiding this comment.
Adding even more props here to pass through to the children is a clear sign this should be refactored into a compositional API.
This was referenced Sep 5, 2023
david-crespo
added a commit
to oxidecomputer/omicron
that referenced
this pull request
Sep 7, 2023
oxidecomputer/console@bfb680e...af6536d * [af6536d5](oxidecomputer/console@af6536d5) skip one flaky test in safari ugh * [84b5177b](oxidecomputer/console@84b5177b) Add full commit range to omicron PR body (oxidecomputer/console#1759) * [26737fd8](oxidecomputer/console@26737fd8) bump pinned omicron to latest * [81e38209](oxidecomputer/console@81e38209) Tweak playwright config (oxidecomputer/console#1758) * [6582b247](oxidecomputer/console@6582b247) increase timeout for image upload error check * [e2147840](oxidecomputer/console@e2147840) Revert mistake commit "curious what it does when we don't say anything" * [7530c3da](oxidecomputer/console@7530c3da) curious what it does when we don't say anything * [bb436357](oxidecomputer/console@bb436357) Fix image upload modal cancel loop (oxidecomputer/console#1755) * [e1558785](oxidecomputer/console@e1558785) add lint-fast npm script * [4614fe6f](oxidecomputer/console@4614fe6f) Fix oxidecomputer/console#1652 - Listbox popover does not move when page scrolls (oxidecomputer/console#1747) * [14685b11](oxidecomputer/console@14685b11) Upgrade playwright eslint plugin to get new rules (oxidecomputer/console#1752) * [2b3d519d](oxidecomputer/console@2b3d519d) Add loading state to ok button in confirm delete modal (oxidecomputer/console#1750) * [0895081b](oxidecomputer/console@0895081b) update readme to reflect RFDs now public * [be687595](oxidecomputer/console@be687595) Bump TS 5.2, Zod, and other deps (oxidecomputer/console#1749)
david-crespo
added a commit
to oxidecomputer/omicron
that referenced
this pull request
Sep 7, 2023
UI changes: * [bb436357](oxidecomputer/console@bb436357) oxidecomputer/console#1755 * [4614fe6f](oxidecomputer/console@4614fe6f) oxidecomputer/console#1747 * [2b3d519d](oxidecomputer/console@2b3d519d) oxidecomputer/console#1750 All changes: oxidecomputer/console@bfb680e...af6536d * [af6536d5](oxidecomputer/console@af6536d5) skip one flaky test in safari ugh * [84b5177b](oxidecomputer/console@84b5177b) oxidecomputer/console#1759 * [26737fd8](oxidecomputer/console@26737fd8) bump pinned omicron to latest * [81e38209](oxidecomputer/console@81e38209) oxidecomputer/console#1758 * [6582b247](oxidecomputer/console@6582b247) increase timeout for image upload error check * [e2147840](oxidecomputer/console@e2147840) Revert mistake commit "curious what it does when we don't say anything" * [7530c3da](oxidecomputer/console@7530c3da) curious what it does when we don't say anything * [bb436357](oxidecomputer/console@bb436357) oxidecomputer/console#1755 * [e1558785](oxidecomputer/console@e1558785) add lint-fast npm script * [4614fe6f](oxidecomputer/console@4614fe6f) oxidecomputer/console#1747 * [14685b11](oxidecomputer/console@14685b11) oxidecomputer/console#1752 * [2b3d519d](oxidecomputer/console@2b3d519d) oxidecomputer/console#1750 * [0895081b](oxidecomputer/console@0895081b) update readme to reflect RFDs now public * [be687595](oxidecomputer/console@be687595) oxidecomputer/console#1749
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1748. This covers all deletes, not just instance create.