-
Notifications
You must be signed in to change notification settings - Fork 16
Add access roles column #2062
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add access roles column #2062
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
The idea was originally that a user role is one applied directly to a single user but the inherited roles comes from a group the user is a member of. Perhaps the issue with that model is that almost all roles come from a group – not even sure if we allow direct role application right now. We can just keep it as a single list of roles. |
Co-authored-by: David Crespo <david-crespo@users.noreply.github.com>
* mostly move role badges logic out of cell * ListPlusCell * siloRole is not used
|
5219886 adds this. It's still not ideal because as @charliepark noted, we're not factoring in roles the user gets from groups because we don't know the groups. But I think it's helpful on net, and it lets us avoid putting text above the table. |
oxidecomputer/console@7c96844...0ed9587 * [0ed9587b](oxidecomputer/console@0ed9587b) turn accessTypeLabel and getBadgeColor functions into records * [420174b4](oxidecomputer/console@420174b4) oxidecomputer/console#2062 * [fc860a25](oxidecomputer/console@fc860a25) oxidecomputer/console#2090
oxidecomputer/console@7c96844...0ed9587 * [0ed9587b](oxidecomputer/console@0ed9587b) turn accessTypeLabel and getBadgeColor functions into records * [420174b4](oxidecomputer/console@420174b4) oxidecomputer/console#2062 * [fc860a25](oxidecomputer/console@fc860a25) oxidecomputer/console#2090

This is a follow-on for #2061.
This PR changes from the current "Silo role" and "Project role" columns to a single "Role" column, showing the "effective" role for each user or group.
It also adds a new

ExpandedCountWithDetailscomponent, which gives us a count and a tooltip that, when hovered over, gives us some additional content.This is a fairly simple first-run component, but we can add more details down the road if we need to. (For example, a design in Figma includes multiple (divided) sections of content as one possible scenario.)