Skip to content

Conversation

@charliepark
Copy link
Contributor

@charliepark charliepark commented Mar 13, 2024

This is a follow-on for #2061.

This PR changes from the current "Silo role" and "Project role" columns to a single "Role" column, showing the "effective" role for each user or group.

Screenshot 2024-03-19 at 5 21 29 PM

It also adds a new ExpandedCountWithDetails component, which gives us a count and a tooltip that, when hovered over, gives us some additional content.
Screenshot 2024-03-19 at 5 23 00 PM
This is a fairly simple first-run component, but we can add more details down the road if we need to. (For example, a design in Figma includes multiple (divided) sections of content as one possible scenario.)

@vercel
Copy link

vercel bot commented Mar 13, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
console ✅ Ready (Inspect) Visit Preview Mar 22, 2024 3:32pm

@benjaminleonard
Copy link
Contributor

benjaminleonard commented Mar 13, 2024

Figma shows a +2, as well as a mix of "User roles" and "Inherited roles". I haven't yet sussed out whether that's an out-of-date data model or whether that still applies and I should account for it in the logic here.

The idea was originally that a user role is one applied directly to a single user but the inherited roles comes from a group the user is a member of. Perhaps the issue with that model is that almost all roles come from a group – not even sure if we allow direct role application right now. We can just keep it as a single list of roles.

Co-authored-by: David Crespo <david-crespo@users.noreply.github.com>
@charliepark charliepark marked this pull request as ready for review March 20, 2024 00:25
* mostly move role badges logic out of cell

* ListPlusCell

* siloRole is not used
@david-crespo
Copy link
Collaborator

5219886 adds this. It's still not ideal because as @charliepark noted, we're not factoring in roles the user gets from groups because we don't know the groups. But I think it's helpful on net, and it lets us avoid putting text above the table.

Screenshot 2024-03-22 at 10 29 51 AM

@charliepark charliepark merged commit 420174b into main Mar 22, 2024
@charliepark charliepark deleted the add_access_roles_column branch March 22, 2024 16:36
david-crespo added a commit to oxidecomputer/omicron that referenced this pull request Mar 22, 2024
david-crespo added a commit to oxidecomputer/omicron that referenced this pull request Mar 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants