Skip to content

Fix broken UX for the Enter key in comboboxes #2540

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
david-crespo merged 14 commits into from
Nov 12, 2024
Merged

Fix broken UX for the Enter key in comboboxes #2540

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
93a5293
Handle enter keypress in comboboxes
charliepark Nov 8, 2024
e0ee6fe
refactor target and host filter forms
charliepark Nov 8, 2024
9af9aac
Continued simplification of shared form UI
charliepark Nov 8, 2024
02392bb
the hits keep coming
charliepark Nov 8, 2024
b3aa75f
add tests re: hitting enter in subform
charliepark Nov 8, 2024
9df4fa8
Merge branch 'main' into enter-in-combobox
charliepark Nov 11, 2024
408bba7
Update interactivity to better handle hitting enter in combobox
charliepark Nov 11, 2024
27fb27d
Merge branch 'main' into enter-in-combobox
charliepark Nov 11, 2024
32257bb
Use 'open' render prop from HeadlessUI to help with combobox interact…
charliepark Nov 12, 2024
b0c7011
refactor .length; start refactoring preventDefault
charliepark Nov 12, 2024
80d73b9
Add onEnter prop; move 'preventDefault when user presses Enter key' i…
charliepark Nov 12, 2024
7caf41a
Add ALL_ISH limit to subnet fetching
charliepark Nov 12, 2024
2b09b72
refactor props, inline functions, make things better
charliepark Nov 12, 2024
1c3108c
clean up comments
charliepark Nov 12, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Loading
Loading