cleanup: delete unused API helper things #2577
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
david-crespo
commented
Nov 23, 2024
| ), | ||
| }) | ||
| } | ||
|
|
Collaborator
Author
There was a problem hiding this comment.
This (and useApiQueries) wasn't used. I kept it around in case we needed it again, but I think if we wanted this now, we'd use the query options helper with map and pass the resulting array of options objects to the built-in useQueries.
david-crespo
commented
Nov 23, 2024
| ? R extends Record<string, unknown> | ||
| ? R | ||
| : never | ||
| : never |
Collaborator
Author
There was a problem hiding this comment.
ResultItem was only used by the old QueryTable, I think.
Contributor
There was a problem hiding this comment.
oof; that's an ugly one
charliepark
approved these changes
Nov 23, 2024
Collaborator
Author
|
The test that failed in Chrome failed twice the same way. It passes locally, but the flake might still be an indicator of something, like maybe I introduced some extra renders that were previously optimized out. Though it would have to come from a a previous PR because one doesn't change any runtime code that's actually used. 
|
david-crespo
added a commit
to oxidecomputer/omicron
that referenced
this pull request
Nov 26, 2024
oxidecomputer/console@6fe6936...653b572 * [653b5725](oxidecomputer/console@653b5725) oxidecomputer/console#2577 * [175d75b7](oxidecomputer/console@175d75b7) oxidecomputer/console#2575 * [3e40ff71](oxidecomputer/console@3e40ff71) oxidecomputer/console#2571 * [034ca87e](oxidecomputer/console@034ca87e) oxidecomputer/console#2567 * [4b4d7fb9](oxidecomputer/console@4b4d7fb9) oxidecomputer/console#2574 * [e116e404](oxidecomputer/console@e116e404) bump web console to latest dogfood version * [67033a32](oxidecomputer/console@67033a32) oxidecomputer/console#2566 * [c4258804](oxidecomputer/console@c4258804) oxidecomputer/console#2568 * [0f922b2e](oxidecomputer/console@0f922b2e) cleanup: move getUseApiQueries down in the file to reduce diff noise elsewhere * [cf7802a7](oxidecomputer/console@cf7802a7) oxidecomputer/console#2565
david-crespo
added a commit
to oxidecomputer/omicron
that referenced
this pull request
Nov 27, 2024
oxidecomputer/console@6fe6936...059c551 * [059c5514](oxidecomputer/console@059c5514) oxidecomputer/console#2487 * [25106d32](oxidecomputer/console@25106d32) oxidecomputer/console#2581 * [653b5725](oxidecomputer/console@653b5725) oxidecomputer/console#2577 * [175d75b7](oxidecomputer/console@175d75b7) oxidecomputer/console#2575 * [3e40ff71](oxidecomputer/console@3e40ff71) oxidecomputer/console#2571 * [034ca87e](oxidecomputer/console@034ca87e) oxidecomputer/console#2567 * [4b4d7fb9](oxidecomputer/console@4b4d7fb9) oxidecomputer/console#2574 * [e116e404](oxidecomputer/console@e116e404) bump web console to latest dogfood version * [67033a32](oxidecomputer/console@67033a32) oxidecomputer/console#2566 * [c4258804](oxidecomputer/console@c4258804) oxidecomputer/console#2568 * [0f922b2e](oxidecomputer/console@0f922b2e) cleanup: move getUseApiQueries down in the file to reduce diff noise elsewhere * [cf7802a7](oxidecomputer/console@cf7802a7) oxidecomputer/console#2565
david-crespo
added a commit
to oxidecomputer/omicron
that referenced
this pull request
Nov 27, 2024
oxidecomputer/console@6fe6936...059c551 * [059c5514](oxidecomputer/console@059c5514) oxidecomputer/console#2487 * [25106d32](oxidecomputer/console@25106d32) oxidecomputer/console#2581 * [653b5725](oxidecomputer/console@653b5725) oxidecomputer/console#2577 * [175d75b7](oxidecomputer/console@175d75b7) oxidecomputer/console#2575 * [3e40ff71](oxidecomputer/console@3e40ff71) oxidecomputer/console#2571 * [034ca87e](oxidecomputer/console@034ca87e) oxidecomputer/console#2567 * [4b4d7fb9](oxidecomputer/console@4b4d7fb9) oxidecomputer/console#2574 * [e116e404](oxidecomputer/console@e116e404) bump web console to latest dogfood version * [67033a32](oxidecomputer/console@67033a32) oxidecomputer/console#2566 * [c4258804](oxidecomputer/console@c4258804) oxidecomputer/console#2568 * [0f922b2e](oxidecomputer/console@0f922b2e) cleanup: move getUseApiQueries down in the file to reduce diff noise elsewhere * [cf7802a7](oxidecomputer/console@cf7802a7) oxidecomputer/console#2565
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Followup to
useQueryTablewith legit types, returns the query data #2567useQueryTable#2571