Add SCIM UI #2926
Add SCIM UI #2926
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
| </div> | ||
| <div className="border-default border-l p-3"> | ||
| <CopyToClipboard text={token.bearerToken} /> | ||
| </div> |
There was a problem hiding this comment.
Think we need design polish from @benjaminleonard. I'd put the yellow bit at the top, for one. Maybe put the expiration at the bottom and display it in one line. Could do without the pseudo form field styling.
There was a problem hiding this comment.
heh just kidding. it's a lot closer to the design than I expected. The pseudo-input it too tall though.
|
UX looks great! The only thing that feels a little off is that the expiration time is mysterious — where is it coming from? This is the admin UI, so it would be weird for it to be outside their control. Maybe in production there would not be a mix of |
|
Ah. It appears the expiration logic is as yet undetermined and I am supposed to be the one reviewing that PR. 
|
|
If we don't pass in a time in the mock service worker it defaults to |
|
Also, without the expiration time we can comment out the |
|
Slight update to remove the "expires" column from the table (also from the post-creation modal). |
|
I did one last design pass, so consider it good to go in that aspect |
|
Added a docs link to the card and tweaked the subheading: 
Updated this warning in consultation with @jmpesp: 
Changed the modal title here, otherwise it's the same: 
Added SAML + SCIM to the silo create form. Not sure about the spaces around the +, maybe it should be 
|
|
Did af34dfa on the assumption James and Mike will accept oxidecomputer/omicron#9301. |
|
Charlie pointed out the JIT one should say it: 
|
There was a problem hiding this comment.
This is ready to go pending two things:
- Nailing down the docs link (I put
/guides/operator/scim, but the release notes PR https://github.com/oxidecomputer/docs/pull/658 suggests it will be here https://docs.oxide.computer/guides/operator/silo-management#_configure_identity_provider) - Merging oxidecomputer/omicron#9301 to make sure the
oxide-scim-prefixing behavior in the mock API is right
|
Took out the docs link, merging. #2953 |
This sets up the system management UI to handle SCIM tokens.
A few outstanding things to note:
Closes #2885
Closes #2886