DTrace and log polish #1773
Merged
DTrace and log polish #1773
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmpesp
approved these changes
Sep 29, 2025
| ss == "wait_quorum" ? "WQ" : | ||
| ss == "wait_active" ? "WA" : | ||
| ss == "connecting" ? "CON" : | ||
| ss == "Active" ? "ACT" : |
There was a problem hiding this comment.
Is there a way to share this function with all the other scripts?
There was a problem hiding this comment.
Maybe... Let me see if I can find an easy way.
I think it's "possible", but I don't want the callers of the scripts have to do too much, or remember too much.
There was a problem hiding this comment.
Let me see if I can find an easier way.. in a follow up commit :)
There was a problem hiding this comment.
I want these changes so I can triage what is going on when multiple downstairs come and go while doing LR
There was a problem hiding this comment.
You could look at what OPTE does, which has a few shared type and function definitions for these kinds of things.
iximeow
added a commit
to oxidecomputer/omicron
that referenced
this pull request
Oct 13, 2025
Propolis changes: * oxidecomputer/propolis#950 * oxidecomputer/propolis#952 * oxidecomputer/propolis#951 * oxidecomputer/propolis#954 * oxidecomputer/propolis#957 * oxidecomputer/propolis#960 * oxidecomputer/propolis#961 * oxidecomputer/propolis#955 Crucible changes: * oxidecomputer/crucible#1773 * oxidecomputer/crucible#1774 * oxidecomputer/crucible#1780 * oxidecomputer/crucible#1778
iximeow
added a commit
to oxidecomputer/omicron
that referenced
this pull request
Oct 18, 2025
Propolis changes: * oxidecomputer/propolis#950 * oxidecomputer/propolis#952 * oxidecomputer/propolis#951 * oxidecomputer/propolis#954 * oxidecomputer/propolis#957 * oxidecomputer/propolis#960 * oxidecomputer/propolis#961 * oxidecomputer/propolis#955 Crucible changes: * oxidecomputer/crucible#1773 * oxidecomputer/crucible#1774 * oxidecomputer/crucible#1780 * oxidecomputer/crucible#1778 Crucible shouldn't have functional changes here, Propolis' big ones are @sunshowers' work moving Propolis to versioned APIs, plus propolis#960 turning the crank on MAXCPU. propolis#961 changes the initial Milan CPU profile one last time before the release in service of propolis#959. Propolis will clear [this bit](https://github.com/oxidecomputer/omicron/blob/d74f5e3f1ae0a378dcdb9795a0ada2426702b046/nexus/src/app/instance_platform/cpu_platform.rs#L423). Later we want to actually set up leaf 8000_001E, so after this merges I'll have a followup to remove that leaf from the inital Milan definition to keep the profile constant when `propolis-server` is smarter about the leaf.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cleanup DTrace printing of downstairs state.
Convert the DsState type into a string before we stuff it into the DTrace probe. We were treating it as a string already on the other side, so why not just send the string we want to begin with. This avoids having to do more complicated processing inside the D scripts. Updated all the DTraces scripts that were using the old method to now expect the new string that is returned for the default display of DsState type.
Updated the default display for DsState to provide a bit more info for states that were "Connecting".
Changed a few log messages from error to warn in the case where we can't send an update message to Nexus.
Fix for various bits in #1772
Here is some sample output from some of the DTrace scripts:
I let the dtrace scripts run while running cargo test and I could see many of the states showing up.
Here is a bunch of noise from that: