-
Notifications
You must be signed in to change notification settings - Fork 4
Reformat elevation tokens #10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Do you think it's worth going with: primary, secondary, tertiary to match our other ordering schemes? |
@benjaminleonard In this case it makes less sense, there is no really a primary elevation, rather layers of it. But I can go with any naming convention that works for the team. |
I'm happy to stick with 1/2/3 One thing we might want to include is a |
Sm/Md/Lg is a viable option. |
@zephraph hoping that declaring the |
I think sm/md/lg might not make sense because elevation covers more than the box shadow. That's all that's implemented here, but we could also add background color and potentially other properties. |
In that case, happy to revert to 1/2/3 |
Yeah, to me that maps the closest. I'm kind of thinking of this similar to z-index but with added details. |
🚀 PR was released in |
I'd like the elevation tokens to have this shape to be a bit more consistent with the rest of our system.
📦 Published PR as canary version:
0.1.1--canary.10.6ffc3bf.0
✨ Test out this PR locally via:
npm install @oxide/design-system@0.1.1--canary.10.6ffc3bf.0 # or yarn add @oxide/design-system@0.1.1--canary.10.6ffc3bf.0