Skip to content

Conversation

zephraph
Copy link
Contributor

@zephraph zephraph commented Oct 31, 2022

I'd like the elevation tokens to have this shape to be a bit more consistent with the rest of our system.

📦 Published PR as canary version: 0.1.1--canary.10.6ffc3bf.0

✨ Test out this PR locally via:

npm install @oxide/design-system@0.1.1--canary.10.6ffc3bf.0
# or 
yarn add @oxide/design-system@0.1.1--canary.10.6ffc3bf.0

@benjaminleonard
Copy link
Collaborator

benjaminleonard commented Nov 1, 2022

Do you think it's worth going with: primary, secondary, tertiary to match our other ordering schemes?

@paryhin

@paryhin
Copy link
Contributor

paryhin commented Nov 1, 2022

@benjaminleonard In this case it makes less sense, there is no really a primary elevation, rather layers of it. But I can go with any naming convention that works for the team.

@benjaminleonard
Copy link
Collaborator

benjaminleonard commented Nov 1, 2022

I'm happy to stick with 1/2/3
I did consider there might be names that might be more descriptive; high/higher/highest or sm/md/lg as it relates to shadow, but I think what we have is probably fine.

One thing we might want to include is a elevation-0 which resets the shadow but thats a dev facing detail if that'd be useful @zephraph?
https://storybook.hotjar.com/?path=/docs/tokens-elevation--page

@paryhin
Copy link
Contributor

paryhin commented Nov 1, 2022

Sm/Md/Lg is a viable option.

@benjaminleonard
Copy link
Collaborator

@zephraph hoping that declaring the elevation-none like this will work—that it would transform as: box-shadow: none. If not, I can remove.

@zephraph
Copy link
Contributor Author

zephraph commented Nov 1, 2022

I think sm/md/lg might not make sense because elevation covers more than the box shadow. That's all that's implemented here, but we could also add background color and potentially other properties.

@benjaminleonard
Copy link
Collaborator

In that case, happy to revert to 1/2/3

@zephraph
Copy link
Contributor Author

zephraph commented Nov 1, 2022

Yeah, to me that maps the closest. I'm kind of thinking of this similar to z-index but with added details. elevation-0 to me says there is no elevation. elevation-1 is the lowest elevation, etc.

@zephraph zephraph merged commit 6ffb44a into figma-tokens Nov 1, 2022
@zephraph zephraph deleted the update-elevation-tokens branch November 1, 2022 16:38
@zephraph
Copy link
Contributor Author

zephraph commented Nov 1, 2022

🚀 PR was released in v0.2.0 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants