Skip to content

Conversation

david-crespo
Copy link
Collaborator

@david-crespo david-crespo commented Dec 17, 2024

I noticed that oxidecomputer/console#2626 adds ton of stuff to the lockfile that doesn't seem necessary — stuff that should be build-time deps only. I think it has to do with things being dependencies that should be in devDependencies.

1.8.2

$ jds
package-lock.json | 1817 +++++++++++++++++++++++++++++++++++++++-----
package.json      |    2 +-
2 files changed, 1613 insertions(+), 206 deletions(-)

1.8.3 canary (this PR)

$ jds
package-lock.json | 865 +++++++++++++++++++++++++++++++++++++++++++--
package.json      |   2 +-
2 files changed, 828 insertions(+), 39 deletions(-)

Still more stuff than I would like to see in the lockfile, but it doesn't really matter. Eventually it might make sense to separate the design tokens from the asciidoc stuff so you can get one without the other.

@david-crespo david-crespo added the patch Increment the patch version when merged label Dec 17, 2024
@david-crespo david-crespo merged commit 941ceb7 into master Dec 17, 2024
5 checks passed
@david-crespo david-crespo deleted the fix-dev-deps branch December 17, 2024 23:28
@augustuswm
Copy link
Collaborator

🚀 PR was released in v1.8.3 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

patch Increment the patch version when merged released

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants