Introduce boxShadow tokens
#14
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I moved |
|
🚀 PR was released in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We discussed this today in chat. I had a bit of a misunderstanding about how tokens worked and sort of encouraged the wrong approach. This is my attempt to correct that.
Changes
elevationtokens to be namedboxShadowelevationUtilitiesto includebackground-color. This is hard-coded in the generator which probably isn't the best but it works for now. We may be able to eventually use compositional tokens for this.borderRadiustokens from color themes when it only needs to be in the main theme📦 Published PR as canary version:
0.4.0--canary.14.31cbf49.0✨ Test out this PR locally via:
npm install @oxide/design-system@0.4.0--canary.14.31cbf49.0 # or yarn add @oxide/design-system@0.4.0--canary.14.31cbf49.0