Provides more flexibility for color edge cases #23
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For any changes to the tailwind tokens, yes, those shouldn't impact the output CSS if they're not used. Any changes we add to a generated CSS file would be included in the production output. |
|
🚀 PR was released in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There's a few edge cases where we need to use some of the base colours directly, and IMO not worth adding more complexity to the tokens to serve these. This is most useful on the RFD site and AsciiDoc styling.
This tweak adds classes like:
text-theme-800.Any unused classes should be stripped out of the production build right?
📦 Published PR as canary version:
0.13.0--canary.23.dca80e7.0✨ Test out this PR locally via:
npm install @oxide/design-system@0.13.0--canary.23.dca80e7.0 # or yarn add @oxide/design-system@0.13.0--canary.23.dca80e7.0