SVG sprites and reusable AsciiDoc components #33
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benjaminleonard
commented
Jul 6, 2023
| // Special handing for the directional arrows which have an odd export naming convention | ||
| if (basename.includes('Direction=')) { | ||
| basename = `carat-${basename.split('=')[1].toLowerCase()}` | ||
| basename = `carat-${basename.split('=')[1].toLowerCase()}-12` |
There was a problem hiding this comment.
I would have just changed the component, but would require refactoring wherever they are used within Figma
Also remove size convert no longer needed
|
Merging updated tokens into here so I can use them on the |
benjaminleonard
changed the title
…sign-system into new-svg-sprites
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tested out here: https://github.com/oxidecomputer/docs/pull/127/files#diff-249eb98d18ed6f3a2fbd89c4149186306e9b61c6d5a84e12335f72004682ec94R3
Generates a type file, to validate icon and size combinations. Currently the icon component needs to be created within the target repo, not imported from here because we need the library (Remix) to serve the SVG.
📦 Published PR as canary version:
0.11.1--canary.33.b7e88c0.0✨ Test out this PR locally via:
npm install @oxide/design-system@0.11.1--canary.33.b7e88c0.0 # or yarn add @oxide/design-system@0.11.1--canary.33.b7e88c0.0