Skip to content

Fix underline color in admonition blocks #83

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Nov 28, 2024
Merged

Fix underline color in admonition blocks #83

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
8c44c1d
fix underline color in admonition blocks
david-crespo Jul 8, 2024
f1d4b27
Merge branch 'master' into admonition-text-decoration
benjaminleonard Nov 28, 2024
a7b36bf
All all underlines, more specificity
benjaminleonard Nov 28, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 20 additions & 7 deletions components/dist/asciidoc.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,7 +59,7 @@
word-wrap: break-word;

text-decoration: underline;
text-decoration-color: rgba(var(--content-accent-tertiary-rgb), 0.8);
text-decoration-color: var(--content-accent-tertiary);
}

/* Use semi-bold for strong */
Expand Down Expand Up @@ -361,6 +361,23 @@
@apply my-[1.5rem] flex px-3 py-3;
}

.asciidoc-body .admonitionblock a {
text-decoration-color: var(--content-success-tertiary);
}

.asciidoc-body .admonitionblock.tip a {
text-decoration-color: var(--base-purple-600);
}

.asciidoc-body .admonitionblock.warning a {
text-decoration-color: var(--content-error-tertiary);
}

.asciidoc-body .admonitionblock.caution a,
.asciidoc-body .admonitionblock.important a {
text-decoration-color: var(--content-notice-tertiary);
}

.asciidoc-body .admonitionblock strong {
@apply text-success;
}
Expand All @@ -378,10 +395,6 @@
@apply border-destructive-secondary;
}

.asciidoc-body .admonitionblock.tip .quoteblock {
border-color: var(--base-purple-500);
}

.asciidoc-body .admonitionblock.warning strong {
@apply text-destructive;
}
Expand Down Expand Up @@ -559,8 +572,8 @@
@apply border-r-0;
}

/*
specificity to handle nested tables
/*
specificity to handle nested tables
todo: check if it's needed in any of the other table styles
*/
.asciidoc-body tbody > tr:last-child > td,
Expand Down
27 changes: 20 additions & 7 deletions components/src/assets/asciidoc.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,7 +59,7 @@
word-wrap: break-word;

text-decoration: underline;
text-decoration-color: rgba(var(--content-accent-tertiary-rgb), 0.8);
text-decoration-color: var(--content-accent-tertiary);
}

/* Use semi-bold for strong */
Expand Down Expand Up @@ -361,6 +361,23 @@
@apply my-[1.5rem] flex px-3 py-3;
}

.asciidoc-body .admonitionblock a {
text-decoration-color: var(--content-success-tertiary);
}

.asciidoc-body .admonitionblock.tip a {
text-decoration-color: var(--base-purple-600);
}

.asciidoc-body .admonitionblock.warning a {
text-decoration-color: var(--content-error-tertiary);
}

.asciidoc-body .admonitionblock.caution a,
.asciidoc-body .admonitionblock.important a {
text-decoration-color: var(--content-notice-tertiary);
}

.asciidoc-body .admonitionblock strong {
@apply text-success;
}
Expand All @@ -378,10 +395,6 @@
@apply border-destructive-secondary;
}

.asciidoc-body .admonitionblock.tip .quoteblock {
border-color: var(--base-purple-500);
}

.asciidoc-body .admonitionblock.warning strong {
@apply text-destructive;
}
Expand Down Expand Up @@ -559,8 +572,8 @@
@apply border-r-0;
}

/*
specificity to handle nested tables
/*
specificity to handle nested tables
todo: check if it's needed in any of the other table styles
*/
.asciidoc-body tbody > tr:last-child > td,
Expand Down
Loading