Skip to content

Conversation

benjaminleonard
Copy link
Collaborator

Still using the older @oxide/react-asciidoc which was causing issues with imports on the docs site.
Removing the listing block, since all I'm using it for is the syntax highlighting which should be handled in the new document format instead now – and importing Section from here doesn't quite work, and needs to be done within the repo importing this lib instead.

@benjaminleonard benjaminleonard added the patch Increment the patch version when merged label Nov 12, 2024
@benjaminleonard
Copy link
Collaborator Author

Oof this is getting messy. This is CJS, but if a ESM library imports this and @oxide/react-asciidoc we get both the CJS and ESM versions imported, leading to shenanigans. Merging for now, but should make this ESM eventually.

@benjaminleonard benjaminleonard merged commit 96b1ebc into master Nov 12, 2024
5 checks passed
@benjaminleonard benjaminleonard deleted the update-react-asciidoc-2 branch November 12, 2024 15:17
@augustuswm
Copy link
Collaborator

🚀 PR was released in v1.5.1 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

patch Increment the patch version when merged released

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants