API views for asset-type objects get dummy "name" and "description" fields

[davepacheco]

This is easy to see when listing Sleds. You get:

$ oxide api /hardware/sleds
{
  "items": [
    {
      "description": "no description",
      "id": "fb0f7546-4d46-40ca-9d56-cbb810684ca7",
      "name": "no-name",
      "service_address": "[fd00:1122:3344:101::1]:12345",
      "time_created": "2022-06-23T22:24:05.468795Z",
      "time_modified": "2022-06-23T22:24:05.468795Z"
    }
  ],
  "next_page": "eyJ2IjoidjEiLCJwYWdlX3N0YXJ0Ijp7InNvcnRfYnkiOiJpZF9hc2NlbmRpbmciLCJsYXN0X3NlZW4iOiJmYjBmNzU0Ni00ZDQ2LTQwY2EtOWQ1Ni1jYmI4MTA2ODRjYTcifX0="
}

Notice the "name" and "description" fields. Sleds have no name or description in the database -- it looks like we cons this up here:

omicron/nexus/src/db/identity.rs

Lines 53 to 61 in c302789

	fn identity(&self) -> external::IdentityMetadata {
	external::IdentityMetadata {
	id: self.id(),
	name: "no-name".parse().unwrap(),
	description: "no description".to_string(),
	time_created: self.time_created(),
	time_modified: self.time_modified(),
	}
	}

This behavior seems confusing, especially since everywhere else Name appears, it's a unique identifier in its collection, but if you had a bunch of Sleds, I think they'd all have the same "name": "no-name".

I noticed this because I'm adding a view for SiloUser, which also have no name, and I'm using the same machinery, but it's particularly confusing for them to get "name": "no-name" since people might think that's a display name or something.

[davepacheco]

This might be related to trying to use pagination on asset-type resources. The Saga view uses a different workaround:

omicron/common/src/api/external/mod.rs

Lines 874 to 891 in c302789

	// TODO-cleanup This object contains a fake `IdentityMetadata`. Why? We
	// want to paginate these objects. http_pagination.rs provides a bunch of
	// useful facilities -- notably `PaginatedById`. `PaginatedById`
	// requires being able to take an arbitrary object in the result set and get
	// its id. To do that, it uses the `ObjectIdentity` trait, which expects
	// to be able to return an `IdentityMetadata` reference from an object.
	// Finally, the pagination facilities just pull the `id` out of that.
	//
	// In this case (as well as others, like sleds and racks), we have ids, and
	// we want to be able to paginate by id, but we don't have full identity
	// metadata. (Or we do, but it's similarly faked up.) What we should
	// probably do is create a new trait, say `ObjectId`, that returns _just_
	// an id. We can provide a blanket impl for anything that impls
	// IdentityMetadata. We can define one-off impls for structs like this
	// one. Then the id-only pagination interfaces can require just
	// `ObjectId`.
	#[serde(skip)]
	pub identity: IdentityMetadata,