Skip to content

[cleanup][db] Not all datasets have associated "services" managing them #2000

@smklein

Description

@smklein

Context: #1954 (comment)

The dataset structure in the database describes some information which assumes each dataset will be managed by an accompanying TCP/IP-based HTTP server:

pub struct Dataset {
#[diesel(embed)]
identity: DatasetIdentity,
time_deleted: Option<DateTime<Utc>>,
rcgen: Generation,
pub pool_id: Uuid,
ip: ipnetwork::IpNetwork,
port: SqlU16,
kind: DatasetKind,
pub size_used: Option<i64>,
}
(see: ip, port).

This isn't universally true; some datasets could exist and be managed by the sled agent (for example, when setting up a local dataset for logging or other debug info).

Metadata

Metadata

Assignees

No one assigned

    Labels

    cleanupCode cleanlinessdatabaseRelated to database access

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions