Remove support for modifying IP subnets of a VPC Subnet #1019
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, the `VpcSubnetUpdate` type allowed users to specify a new IPv4 or IPv6 subnetwork for the VPC Subnet. That is now only supported by creating a new subnet.
Collaborator
Author
|
This will address #964 |
Collaborator
Author
|
There was another transient timeout failure here, presumably due to oversubscription of the macOS test runners again. |
smklein
approved these changes
May 5, 2022
Collaborator
smklein
left a comment
smklein
left a comment
There was a problem hiding this comment.
LGTM, couple questions on the tests
leftwo
pushed a commit
that referenced
this pull request
Nov 15, 2023
Crucible changes: test-crudd can collect more info, test_up can be gentle (#997) Decrypt without holding the downstairs lock (#1021) Add raw file backend (#991) Don't hold the Downstairs lock while doing encryption (#1019) Antagonize the Crucible Agent (#1011) The Pantry should reject non-block sized writes (#1013) Propolis changes: Just the commit that updates Crucible
leftwo
added a commit
that referenced
this pull request
Nov 16, 2023
Crucible changes: test-crudd can collect more info, test_up can be gentle (#997) Decrypt without holding the downstairs lock (#1021) Add raw file backend (#991) Don't hold the Downstairs lock while doing encryption (#1019) Antagonize the Crucible Agent (#1011) The Pantry should reject non-block sized writes (#1013) Propolis changes: make headroom for linux virtio/9p client impl (#565) Guarantee Tokio access for Entity methods --------- Co-authored-by: Alan Hanson <alan@oxide.computer>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, the
VpcSubnetUpdatetype allowed users to specify a newIPv4 or IPv6 subnetwork for the VPC Subnet. That is now only supported
by creating a new subnet.