Tweak names of device auth params structs as a quick fix for oxide.ts #1303
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
david-crespo
added a commit
to oxidecomputer/console
that referenced
this pull request
Jun 29, 2022
plotnick
approved these changes
Jun 29, 2022
Contributor
plotnick
left a comment
plotnick
left a comment
There was a problem hiding this comment.
Cool, thanks for the quick workaround!
david-crespo
added a commit
to oxidecomputer/console
that referenced
this pull request
Jun 29, 2022
* Add client authn verification page * Update for renamed device auth endpoints * Bump OMICRON_VERSION * prove oxidecomputer/omicron#1303 fixes it * make typescript happy * use omicron version that's on main now that it's merged * quick polish on auth and success state Co-authored-by: David Crespo <david.crespo@oxidecomputer.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
oxide.ts needs better namespacing of its types (oxidecomputer/oxide.ts#121), but as a quick fix we can change the names here so they don't create conflicts.