Skip to content

Update the dbwipe commands for parity with dbinit #1317

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jun 30, 2022
Merged

Update the dbwipe commands for parity with dbinit #1317

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
a1ec4cd
Update the dbwipe commands for parity with dbinit
smklein Jun 30, 2022
1046a45
Merge branch 'main' into update-wipe-too
smklein Jun 30, 2022
1516eac
Merge branch 'main' into update-wipe-too
smklein Jun 30, 2022
06ca2fc
Do a silly thing
smklein Jun 30, 2022
1d0b4c2
Create the DB too
smklein Jun 30, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions common/src/sql/dbwipe.sql
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,5 +8,15 @@
* NOTE: the database and user names MUST be kept in sync with the
* initialization code and dbwipe.sql.
*/

/*
* This is silly, but we throw an error if the user was already deleted.
* Create the user so we can always delete it.
*/
CREATE DATABASE IF NOT EXISTS omicron;
CREATE USER IF NOT EXISTS omicron;

ALTER DEFAULT PRIVILEGES FOR ROLE root REVOKE ALL ON TABLES FROM omicron;
Copy link
Collaborator

@davepacheco davepacheco Jun 30, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If this is run by the same user that ran dbinit, I think the FOR ROLE root is unnecessary. I mention this because it will be wrong if dbinit wasn't run under that role. I think we could also use FOR ALL ROLES.


DROP DATABASE IF EXISTS omicron;
DROP USER IF EXISTS omicron;