buildomat: reshape Helios CI jobs #1444
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change splits out the Helios deploy check into a separate job, "check-omicron-deployment (helios)", which should shorten the critical path through the build-and-test job where it used to be. This new job has a name of the same form as the Actions equivalent on the Linux and Macintosh side. In addition, the build and test job should use the new builder-only prerequisites script; we're not rebooting into the OPTE bits it would install anyway so this is wasted time. Finally, we're renaming the build and test job to "build-and-test (helios)" to align the naming with the Actions jobs.
Collaborator
Author
|
NB: as part of this, I guess we would have to reconfigure the required checks for |
Collaborator
Author
|
It seems that this gets the Helios build-and-test job back down to ~53 minutes instead of ~1h07m. |
iliana
approved these changes
Jul 18, 2022
leftwo
pushed a commit
that referenced
this pull request
Sep 18, 2024
Crucible changes:
Make crutest use BlockIO trait instead of a Guest (#1452)
Use new syncfs syscall (#1427)
Increment write backpressure before deferred encryption (#1444)
Use RAII handles for backpressure (#1443)
Fine-tuning backpressure clamping, and API cleanups (#1442)
Fix outdated comment (#1447)
Update Rust crate rusqlite to 0.32 (#1418)
Fix write reordering bug (#1448)
Remove `history_file` (#1446)
Remove optionality for `BlockRes` in `DeferredWrite` (#1441)
Propolis changes
instance spec rework: tighten up component naming (#761)
instance spec rework: remove most dependencies on `InstanceSpecV0` from propolis-server (#757)
fix new 1.81.0 warning and clippy error (#760)
standalone: be more helpful with bad block device configs (#758)
leftwo
added a commit
that referenced
this pull request
Sep 18, 2024
Crucible changes:
Make crutest use BlockIO trait instead of a Guest (#1452)
Use new syncfs syscall (#1427)
Increment write backpressure before deferred encryption (#1444)
Use RAII handles for backpressure (#1443)
Fine-tuning backpressure clamping, and API cleanups (#1442)
Fix outdated comment (#1447)
Update Rust crate rusqlite to 0.32 (#1418)
Fix write reordering bug (#1448)
Remove `history_file` (#1446)
Remove optionality for `BlockRes` in `DeferredWrite` (#1441)
Propolis changes
instance spec rework: tighten up component naming (#761)
instance spec rework: remove most dependencies on `InstanceSpecV0` from
propolis-server (#757)
fix new 1.81.0 warning and clippy error (#760)
standalone: be more helpful with bad block device configs (#758)
Co-authored-by: Alan Hanson <alan@oxide.computer>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change splits out the Helios deploy check into a separate job,
"check-omicron-deployment (helios)", which should shorten the critical
path through the build-and-test job where it used to be. This new job
has a name of the same form as the Actions equivalent on the Linux and
Macintosh side.
In addition, the build and test job should use the new builder-only
prerequisites script; we're not rebooting into the OPTE bits it would
install anyway so this is wasted time.
Finally, we're renaming the build and test job to "build-and-test
(helios)" to align the naming with the Actions jobs.