Skip to content

Conversation

@davepacheco
Copy link
Collaborator

RFD 4 says that names must be 1-63 characters long and we validate this. In the database schema, most names use STRING(63). A few were using other lengths so I'm updating them to be consistent. This prevents us from storing a field that we won't be able to deserialize. (They might actually deserialize because we don't check that...but that would be a separate bug.)

I skipped two:

  • update_available_artifact has a "name" but it's not stored in Rust as a Name so I didn't touch it
  • saga has a "template_name" but it's going away in update to steno 0.2.0 #1532

@davepacheco davepacheco merged commit a7445c7 into main Aug 2, 2022
@davepacheco davepacheco deleted the db-name-lengths branch August 2, 2022 15:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants