some database name lengths are not right #1533
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
RFD 4 says that names must be 1-63 characters long and we validate this. In the database schema, most names use
STRING(63). A few were using other lengths so I'm updating them to be consistent. This prevents us from storing a field that we won't be able to deserialize. (They might actually deserialize because we don't check that...but that would be a separate bug.)I skipped two:
Nameso I didn't touch it