[api] Separate internal, external interfaces #167
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Adds the `VPC`, `VPCSubnet` and `VNIC` types, including internal control plane representations, client views, and database types. - Implements some required traits for generating JSON schema and serializing to/from PostgreSQL wire formats. Note that the MAC address type is serialized in the database as a string, as CockroachDB doesn't currently support the PostgreSQL MACADDR type.
smklein
changed the title
Collaborator
Author
|
Merged with changes in #163 ; using that as upstream until it is merged |
| pub trait Object { | ||
| type View: Serialize + Clone + Debug; | ||
| fn to_view(&self) -> Self::View; | ||
| } |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements part of https://github.com/oxidecomputer/rfd/tree/0189/rfd/0189
It largely leaves the database types untouched, as they're significantly more complicated. As a result, the database types are (for the most part) still using the external API types.