Skip to content

Conversation

@smklein
Copy link
Collaborator

@smklein smklein commented Oct 7, 2022

This is intended to be used by oxidecomputer/console#1214 when displaying system metrics

@smklein
Copy link
Collaborator Author

smklein commented Oct 7, 2022

I separated this from #1782 because I wanted to get feedback on this piece in isolation - sounds like @david-crespo is struggling on the console side to actually get the UUID of the current silo, which needs to be supplied to the /system/metrics endpoint for filtering.

If we consider it a bad idea to expose the current silo ID to the user, we could try to internalize this, by looking up and magically applying the right "silo id" to the /system/metrics endpoint, but that feels a little hairy, especially since that endpoint may also be used to view information about different silos from an operator point-of-view.

@david-crespo
Copy link
Contributor

david-crespo commented Oct 7, 2022

As a proper fix (I consider this change a temporary workaround) I was thinking that rather than magically applying the silo filter to /system/metrics (which I agree is problematic), there would be a silo-scoped endpoint like /metrics that would take the lack of a filtering ID to be "global" i.e., the current silo.

@david-crespo david-crespo merged commit 0190de8 into main Oct 7, 2022
@david-crespo david-crespo deleted the expose-silo-id branch October 7, 2022 17:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants