Fix clippy warnings on illumos #1847
Conversation
| vni: &Vni, | ||
| mac: &MacAddr6, | ||
| ) -> Vec<FirewallRule> { | ||
| #[allow(clippy::map_flatten)] |
There was a problem hiding this comment.
Justification: the structure of this whole loop is that we accumulate a doubly nested vector of translated rules (one for each host and protocol) and then flatten it twice to get a single vector that covers everything. If we wrote the flattening as .flat_map(...).flatten() as suggested by clippy, it would totally obscure the structure of the loop. It seems correct to replace one level of .map(...).flatten() with .flat_map(...), but (at least in this case) not two.
There was a problem hiding this comment.
Sounds reasonable. I'd consider a comment explaining that (even if it's just "Clippy doesn't like .map(...).flatten() below, but in this case it's clearer than the alternative."). Up to you.
| vni: &Vni, | ||
| mac: &MacAddr6, | ||
| ) -> Vec<FirewallRule> { | ||
| #[allow(clippy::map_flatten)] |
There was a problem hiding this comment.
Sounds reasonable. I'd consider a comment explaining that (even if it's just "Clippy doesn't like .map(...).flatten() below, but in this case it's clearer than the alternative."). Up to you.
The source file
sled-agent/src/opte/illumos/firewall_rules.rsintroduced as part of #1636 had some clippy warnings, but they are only reported on illumos because that file is conditionally compiled.