RFD-322 PoC Revision 2 #1995
Merged
RFD-322 PoC Revision 2 #1995
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
karencfv
reviewed
Nov 30, 2022
Contributor
karencfv
left a comment
karencfv
left a comment
There was a problem hiding this comment.
This is looking great! I like it, a lot of the complexity has been reduced
| params::InstanceSelector { | ||
| instance: NameOrId::Name(instance_name), | ||
| project: Some(NameOrId::Name(project_name)), | ||
| organization: Some(NameOrId::Id(organization_id)), |
Contributor
There was a problem hiding this comment.
I see, tbe optional parent identifiers aren’t a problem because you were already doing this whole pattern match on the valid combinations anyway. So encoding them into the type was redundant and way harder for spec generation.
Contributor
|
Great improvement! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an updated approach to #1957 that was spawned from feedback from @ahl. The main feedback here is that we'd like the CLI and API be consistent. In the cli we'll probably use
--projectand--organizationnot--project_id,--project_name. The over-specification of params and their types didn't actually make the resulting API any simpler... in fact, it introduced extra failure modes where you could have combinations of selectors for the same resource.I'm putting this up as a separate PR to merge on the first just so folks can take a peek at it and voice any feedback/concerns before I merge them together.
Differences from #1957
InstanceSelector,ProjectSelector) are structs now instead of enums.NameOrIdfor query parameters reducingproject_idandproject_namedown to justprojectNameOrIdis no longer necessary