Skip to content

[nexus] Project and VPC creation are now sagas #2081

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 13 commits into from
Dec 27, 2022
Merged

[nexus] Project and VPC creation are now sagas #2081

merged 13 commits into from
Dec 27, 2022

Conversation

@smklein
Copy link
Collaborator

@smklein smklein commented Dec 19, 2022

  • Adds a VPC creation saga
  • Adds a project creation saga, which uses the VPC creation as a subsaga
  • Does not yet add undo actions; that's follow-up work

Part of #2059

@smklein smklein mentioned this pull request Dec 20, 2022
Open
16 tasks
@smklein smklein mentioned this pull request Dec 22, 2022
Merged
14 tasks
Base automatically changed from more-sagas to main December 22, 2022 18:14
plotnick
plotnick approved these changes Dec 27, 2022
View reviewed changes
Copy link
Contributor

@plotnick plotnick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry I missed this; I saw the "review requested" notification for #2086, but somehow not this one. In conjunction with that, this looks great.

@smklein smklein merged commit 6084fdf into main Dec 27, 2022
@smklein smklein deleted the project-creation-saga branch December 27, 2022 19:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@plotnick plotnick plotnick approved these changes

@just-be-dev just-be-dev Awaiting requested review from just-be-dev

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@smklein @plotnick