Skip to content

[nexus] Make instance deletion actions idempotent #2096

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 53 commits into from
Dec 29, 2022
Merged

[nexus] Make instance deletion actions idempotent #2096

merged 53 commits into from
Dec 29, 2022

Conversation

@smklein
Copy link
Collaborator

@smklein smklein commented Dec 28, 2022 •
edited
Loading

Part of #2094

smklein added 30 commits December 15, 2022 22:38
@smklein
[sagas] Make a macro to simplify declaring saga actions
b2a2ba1
@smklein
ignore rustdoc
f399ff7
@smklein
[nexus] Instance Deletion is now a saga
66cf0c0
@smklein
[nexus] Project and VPC creation are now sagas
828ed21
@smklein
Merge branch 'main' into saga-macro
2e0a199
@smklein
Merge branch 'main' into saga-macro
533ee76
@smklein
Move some lazy_static to once_cell
6abce08
@smklein
Merge branch 'main' into saga-macro
169ed10
@smklein
Extend docs
29a3ab5
@smklein
Merge branch 'main' into saga-macro
3b62a6a
@smklein
Merge branch 'saga-macro' into more-sagas
05cbd9d
@smklein
Merge branch 'more-sagas' into project-creation-saga
f7f5fbe
@smklein
[vpc_create] Add undo actions
2f89973
@smklein
[vpc_create] Add tests for idempotency, fix things
b9fef96
@smklein
[nexus] Make project creation unwind safe, add tests
d68c763
@smklein
fix project lookup
9a8504b
@smklein
Lookup project when deleting to avoid rcgen issue during unwind
79271d2
@smklein
[nexus] Make snapshot deletion a saga
23801dd
@smklein
[nexus] Add basic test for snapshot create
80932d8
@smklein
Merge branch 'main' into project-creation-saga
bfc6048
@smklein
Merge branch 'project-creation-saga' into vpc-creation-saga-idempotent
f9c635a
@smklein
Merge branch 'vpc-creation-saga-idempotent' into project-creation-sag…
8c01fcd 
…a-idempotent
@smklein
Merge branch 'project-creation-saga-idempotent' into snapshot-delete-…
3f37a48 
…saga
@smklein
Merge branch 'snapshot-delete-saga' into snapshot-create-saga-idempotent
e1a5e5c
@smklein
fix node names
163d9c5
@smklein
Merge branch 'snapshot-delete-saga' into snapshot-create-saga-idempotent
fedfbb8
@smklein
Verify clean slate in snapshot test, add volume check to disk test
ffdc483
@smklein
Passing snapshot unwind test
839fac6
@smklein
More state validation
e4190e8
@smklein
fmt
c4b16ce
@smklein smklein mentioned this pull request Dec 28, 2022
Open
13 tasks
andrewjstone
andrewjstone approved these changes Dec 28, 2022
View reviewed changes
Copy link
Contributor

@andrewjstone andrewjstone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

Base automatically changed from instance-create-idempotency to main December 29, 2022 16:01
@smklein smklein enabled auto-merge (squash) December 29, 2022 16:33
@smklein smklein merged commit 1dfe47c into main Dec 29, 2022
@smklein smklein deleted the instance-delete-idempotency branch December 29, 2022 17:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@andrewjstone andrewjstone andrewjstone approved these changes

@bnaecker bnaecker Awaiting requested review from bnaecker

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@smklein @andrewjstone