[wicket] move wizard into its own file #2164
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Created using spr 1.3.4
Created using spr 1.3.4
andrewjstone
approved these changes
Jan 13, 2023
Contributor
andrewjstone
left a comment
andrewjstone
left a comment
There was a problem hiding this comment.
LGTM! Welcome to the world of wicket @sunshowers
sunshowers
deleted the
sunshowers/spr/wicket-move-wizard-into-its-own-file
branch
smklein
pushed a commit
that referenced
this pull request
Jan 18, 2023
Currently, wizard is the main entrypoint for wicket. To support uploading artifacts, We're going to change it so that it has to go through a clap command layer. Also add a `default-run` so that `cargo run -p wicket` runs the wicket binary.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, wizard is the main entrypoint for wicket. To support
uploading artifacts, We're going to change it so that it has to go
through a clap command layer.