Add collection tokens into oximeter #2188
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Attempts to improve the
force_collectmethod onOximeter:omicron/oximeter/collector/src/lib.rs
Lines 550 to 556 in e69a5a3
This method triggers the collection of metrics from Producers, but Oximeter is a pipeline, and this just sends an initial message, rather than ensuring that those metrics have made their way to Clickhouse.
This PR weaves an optional "token" through this pipeline, so a caller can call
force_collectand confidently know "if any metrics were ready to be produced before, they'll be in Clickhouse after this call".Fixes #2186