Skip to content

RFD-322: /v1/snapshots #2347

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Feb 11, 2023
Merged

RFD-322: /v1/snapshots #2347

merged 4 commits into from
Feb 11, 2023

Conversation

@just-be-dev
Copy link
Contributor

@just-be-dev just-be-dev commented Feb 10, 2023 •
edited
Loading

Adds the /v1/ snapshot APIs

GET    /v1/snapshots            # List snapshots
POST   /v1/snapshots            # Create a snapshot
GET    /v1/snapshots/{snapshot} # Get a snapshot
DELETE /v1/snapshots/{snapshot} # Delete a snapshot

@just-be-dev just-be-dev mentioned this pull request Feb 10, 2023
Open
22 tasks
@just-be-dev just-be-dev changed the title Start on snapshot v1 conversion RFD-322: /v1/snapshots Feb 10, 2023
@just-be-dev just-be-dev marked this pull request as ready for review February 10, 2023 22:24
david-crespo
david-crespo approved these changes Feb 10, 2023
View reviewed changes
Copy link
Contributor

@david-crespo david-crespo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@just-be-dev just-be-dev merged commit 92aec03 into main Feb 11, 2023
@just-be-dev just-be-dev deleted the rfd-322-snapshots branch February 11, 2023 13:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@david-crespo david-crespo david-crespo approved these changes

@leftwo leftwo Awaiting requested review from leftwo

@ahl ahl Awaiting requested review from ahl

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@just-be-dev @david-crespo