Delete /timeseries/schema
#2591
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
I think we may want to nuke this instead. See this issue and this comment thread for more background. I'm not sure we want to expose all the timeseries schema to customers if they have no way of querying them. @ahl that was your comment initially, do you have any more thoughts on it at this point? |
Contributor
Author
|
I am always happy to delete things outright. |
Contributor
|
I agree, I think we should kill it. We can always reintroduce something similar if we have a product need for it. |
Collaborator
|
I'm on board. We can fish it out of the history if needed, and the internal methods for grabbing these from ClickHouse can stick around. |
david-crespo
changed the title
/timeseries/schema
just-be-dev
approved these changes
Mar 17, 2023
# Conflicts: # nexus/src/external_api/http_entrypoints.rs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I don't think anyone is using this, so I'm breaking the rules and converting it straight.See below. Closes #1331.