Only wipe crypt/zone if this is the first time we're mounting it #3638
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iliana
approved these changes
Jul 15, 2023
Contributor
iliana
left a comment
iliana
left a comment
There was a problem hiding this comment.
Seems like this fixes the issue!
andrewjstone
approved these changes
Jul 15, 2023
smklein
added a commit
that referenced
this pull request
Jul 17, 2023
…ore (#3642) This builds on #3638 , with a slightly more fine-tuned mechanism. - `crypt/zone` is created on new U.2s, if it doesn't already exist - If it **does** exist, then Sled Agent needs to make a call: Should I delete the dataset, possibly containing zones from last boot, or should I leave it alone (for idempotency)? - In #3638 , we used "was the filesystem previously mounted" as a proxy for this information. However, in cases where the sled agent reboots, this information gets out-of-date -- the filesystem could be mounted, but sled agent should remove the corresponding dataset. This PR introduces a filesystem property, simply called 'oxide:agent', which is a randomly generated string created statically during the lifetime of the Sled Agent. If the sled agent reboots, this value will be regenerated, which instructs the sled agent to wipe `crypt/zone` and re-create it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3637