-
Notifications
You must be signed in to change notification settings - Fork 62
Add Rust Cache Action to Github Actions #498
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Note: this does not yet add a cache for the buildomat action, but it at least makes the Github actions much faster when third-party dependencies are unchanged. |
david-crespo
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
incredible!
I believe this particular image is referencing the cache for Clickhouse/Cockroach being downloaded: omicron/.github/workflows/rust.yml Lines 97 to 116 in ab8872a
This is the part of the action where we check for a cache: |
|
I meant the build taking 5 minutes! |
oh yeah I hope so lol |
|
As discussed in chat, is there a way to make the use of the cache conditional so we can skip it on main? We want to be running clean builds at least some of the time, and main is a good spot for that because we're never waiting for CI to pass there. We would also have to turn off whatever it is that skips builds on main when it thinks the PR already handled it. |
25dc616 to
80108bd
Compare



This PR integrates the Rust Cache Action to cache third party dependencies. It exclusively applies them to Github workflows, and does not yet optimize Buildomat. The cache step is skipped on
mainso it will always build from scratch there.Before Cache:

After Cache:
