save test outputs from failed GitHub Actions #546
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Author
|
Commit 09405d6 seems to work at least somewhat. I deliberately injected a test failure that would leave a log file around. We have this output from the upload action: The artifact is hidden at the bottom of this page: And although it's the zip analog of a tarbomb, it seems to contain the log files: It does not appear to have picked up the database files though. |
Collaborator
Author
|
Some weird things about this:
My real question at this point is: was the cockroachdb directory actually there at this phase? We'll see if the step-by-step debug output shows up for the next run. If not, I'll add a dummy step to print out everything in Update: I tried this locally and the directory wasn't there. We seem to clean this up even on unsuccessful tests. |
Collaborator
Author
|
The latest change preserves the database directory when the Besides that, I still want to verify that the artifacts generated for the latest build include what they should. |
Collaborator
Author
|
The artifact from the latest change looks like what I'd expect: It also doesn't have any extra database directories. |
Collaborator
Author
|
Here are the remaining things I'd like to do on this PR:
|
Collaborator
Author
|
Verifying the artifacts from the run on 8a9c27d: (namely, we have one log file at the root, and it names the temporary directory, which is the only other thing contained at the root, and that directory appears to look like a complete cockroachdb data directory) Similarly for the MacOS artifact: |
davepacheco
commented
Dec 23, 2021
| #[tokio::test] | ||
| async fn test_organization() { | ||
| let logctx = dev::test_setup_log("test_database"); | ||
| let logctx = dev::test_setup_log("test_organization"); |
Collaborator
Author
There was a problem hiding this comment.
Unrelated typo in the log file name that I found while doing this.
| #[allow(unused_must_use)] | ||
| if let Some(temp_dir) = self.temp_dir.take() { | ||
| temp_dir.close(); | ||
| /* |
Collaborator
Author
There was a problem hiding this comment.
This is mentioned in the PR comments: we now deliberately save the database directory if you don't explicitly clean it up after a successful test.
| assert_eq!(rows.len(), 0); | ||
| client2.cleanup().await.expect("second connection closed ungracefully"); | ||
|
|
||
| db1.cleanup().await.expect("failed to clean up first database"); |
Collaborator
Author
There was a problem hiding this comment.
These tests always should have been cleaning up the database instead of relying on the best-effort Drop impl. Now that the Drop impl doesn't clean these up any more, they were leaking the directory without this fix.
davepacheco
changed the title
andrewjstone
approved these changes
Dec 23, 2021
Contributor
andrewjstone
left a comment
andrewjstone
left a comment
There was a problem hiding this comment.
AFAICT, this should work :)
| - name: Archive any failed test results | ||
| if: ${{ failure() }} | ||
| # actions/upload-artifact@v2.3.1 | ||
| uses: actions/upload-artifact@82c141cc518b40d92cc801eee768e7aafc9c2fa2 |
Contributor
There was a problem hiding this comment.
Just curious, why the sha rather than a version (which requires a comment) ?
Collaborator
Author
There was a problem hiding this comment.
I'm not sure how well-founded it is, but following the advice in https://julienrenaux.fr/2019/12/20/github-actions-security-risk/.
davepacheco
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #542. Do this for GitHub Actions too.
I haven't tested this yet.