Gracefully terminate CRDB #553
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davepacheco
approved these changes
Dec 23, 2021
Collaborator
davepacheco
left a comment
davepacheco
left a comment
There was a problem hiding this comment.
Looks good.
Is it worth pulling in nix just for a safe kill? I think the libc impl is totally sound and we use it in a few other places. (I'm only worried about build times, honestly.)
Collaborator
Author
Nix is only like ~240KB, and for a test utility, I figured that would be okay, but sure, I've updated the PR to use unsafe libc calls directly instead. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should fix #540 by ensuring that no "temporary files" pointing to the seed directory exist after shutdown.
Additionally, adds an assertion that the
temp-dirs-record.txtfile is empty (as suggested in cockroachdb/cockroach#74231)