#[serde(flatten)] identity field in NetworkInterface

[david-crespo]

Followup to #581 to include NetworkInterface change I left out because I couldn't get it to work.

Turns out NetworkInterface wasn't working because I forgot to update the sled agent OpenAPI spec. Presumably there was a failure of test_sled_agent_openapi_sled (was able to get a failure when I ran that test locally), but it must have gotten buried cargo test output, so I missed it.

[davepacheco]

Hmm. How did it not break in CI on commit e8c31ef?

[david-crespo]

That one didn't have the NetworkInterface change in it. Let me see if I can find a run that did.

[david-crespo]

Here's a run that should have had a failure for test_sled_agent_openapi_sled but does not.

https://github.com/oxidecomputer/omicron/runs/4744873353?check_suite_focus=true

Only these much harder to debug failures turned up:

 failures:
    integration_tests::disks::test_disks
    integration_tests::instances::test_instances_create_reboot_halt
    integration_tests::instances::test_instances_delete_fails_when_running_succeeds_when_stopped
    integration_tests::subnet_allocation::test_subnet_allocation

[davepacheco]

Sorry -- I think I misread the issue here. I thought you were saying that the change for #581 had neglected to update the sled agent spec and as a result was causing a test failure on "main".

[david-crespo]

Right, sorry. Initially that was true in that PR, but I fixed it there. Will update the description.

[david-crespo]

@davepacheco thinks cargo test will bail on running other targets if one target fails. So in this case the integration tests failed, and the sled agent tests that would have alerted me to my mistake did not run.