Skip to content

Conversation

@ahl
Copy link
Contributor

@ahl ahl commented Mar 10, 2022

This will require additional work in terms of the specific tags and their descriptions. I expect the external docs link will point to our product documentation.

@ahl ahl requested review from davepacheco and jessfraz March 10, 2022 23:26
@jessfraz
Copy link
Contributor

wait does this generate the openapi spec tho? with tags

@ahl
Copy link
Contributor Author

ahl commented Mar 10, 2022

oy. it should. one second..

"name": "hidden",
"description": "TODO operations that will not ship to customers",
"externalDocs": {
"url": "http://oxide.computer/docs/#xxx"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These are "https://docs.oxide.computer/api/{lowercase tag name}" if you want to fill them in with the real url

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But I don't technnically need that right now anyways but just so you know

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These aren't links to the API documentation; they're links to the product documentation.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah ha, I see, like a tutorial? https://docs.oxide.computer/tutorials/{thing} ?

Copy link
Contributor

@jessfraz jessfraz Mar 10, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

or the thing in the rack? regardless I guess it doesn't really matter

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah gotcha!

@ahl ahl merged commit df1b835 into main Mar 11, 2022
@ahl ahl deleted the tag-details branch March 11, 2022 07:40
zephraph added a commit that referenced this pull request Jul 11, 2022
zephraph added a commit that referenced this pull request Jul 12, 2022
* first pass at implementing /by_id/ routes

* Restore text that failed to get written when I ran out of space

* Add docstrings

* Fixup formatting

* Fix compiler errors

* Update config

* Reverse by_id/resource name order

* reorganize imports

* Reorganize id lookup implementation code

* Reorganize implementations, fix some tags

* by_id to by-id

* Prefix vpc resources

* Add mechanism to valid auth endpoints with ids

* Add coverage for by-id unauthed tests

* Fix comment

* Fix unauth tests

* Restore test that was added by @ahl in #751

* Improve the setup req comment
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants