Introduce concept of Silos #814
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add silos, which will isolate organizations, and provide a namespace for
users and groups.
This required adding Silo id to Actor, so users that have authenticated
now have an associated Silo id that can be used to restrict organization
lookup.
Silos can be created, read, and deleted. Modification is a TODO. Silos
can be marked discoverable or not, to support a tenancy model where
users and resources are strongly isolated from each other.
A few tests have been modified to use authn_as because an earlier
version of this branch added OpContext to every endpoint, but that was
reverted because the blast radius of the PR would have been too large.
What remains are a few modified tests that make authenticated calls.
When all endpoints are protected and each datastore function has an
OpContext, Silo can be looked up on Actor. For now, there are places
hard coding as the built-in Silo.
Still TODO:
- authz for silos and silo users
- some testing is dependent on ^
- PUT /silos/{name}
- building on top of silos
Contributor
Author
|
note: original PR at #747 |
Collaborator
|
Is this basically the same as #747 plus sync'd with "main"? If so are there any tricky parts of the rebase/merge that you'd like eyes on? |
Contributor
Author
yes, and I think a very quick once over would help make sure I rebased correctly, but otherwise this is the same. |
davepacheco
approved these changes
Mar 25, 2022
This was referenced Apr 1, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add silos, which will isolate organizations, and provide a namespace for
users and groups.
This required adding Silo id to Actor, so users that have authenticated
now have an associated Silo id that can be used to restrict organization
lookup.
Silos can be created, read, and deleted. Modification is a TODO. Silos
can be marked discoverable or not, to support a tenancy model where
users and resources are strongly isolated from each other.
A few tests have been modified to use authn_as because an earlier
version of this branch added OpContext to every endpoint, but that was
reverted because the blast radius of the PR would have been too large.
What remains are a few modified tests that make authenticated calls.
When all endpoints are protected and each datastore function has an
OpContext, Silo can be looked up on Actor. For now, there are places
hard coding as the built-in Silo.
Still TODO: