-
Notifications
You must be signed in to change notification settings - Fork 62
[sled-agent] Launch from bootstrap agent, derive bootstrap addresses, allocate sled /64s #904
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
jmpesp
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, some questions:
sled-agent/src/rack_setup/service.rs
Outdated
| // NOTE: This is a "point-of-no-return" -- before sending any requests | ||
| // to neighboring sleds, ensure that we've recorded our plan to durable | ||
| // storage. This way, if the RSS power-cycles, it can idempotently | ||
| // execute the same allocation plan. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the way this is worded seems like it's not done yet. did create_plan perform a flush to durable storage?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll move the comment up, indicating that it is supposed to refer to the moment create_plan completes.
create_planperforms the write to durable storage.- It's not calling flush explicitly, but I believe it's being implicitly called when the
tokio::fs::write- which callsstd::fs::write- which itself callsFile::create-drops the createdFileobject.
| // This modifies global state of the target machine, creating | ||
| // an address named "bootstrap6", akin to what the bootstrap | ||
| // agent should do. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is this cleaned up after the test?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It will now.
bnaecker
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks really good. I have a few clarifying comments and questions, but overall a +1 from me!
|
Looks like you've got a test flake on the Otherwise, LGTM! |
Bootstrap Agent
/64for which it should be responsible. Store configuration data to local storage withinOMICRON_CONFIG_PATHto automatically launch these agents on reboot, after RSS setup.PeerMonitorObserverstructure that may be used to await the notification of new peers within the bootstrap agent.Sled Agent
RSS
Configs (mostly in
smf/)TODO
PeerMonitorObserverstructure, maybe it can be simplifiedTODOs for later PRs (but which should be unblocked now)
Fixes #821