always move uploaded TUF repos to the replication task #9213
+24
−24
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sunshowers
reviewed
Oct 15, 2025
nexus/src/app/update.rs
Outdated
Comment on lines
104
to
107
| // In theory this should never happen; `Sender::send` | ||
| // returns an error only if the receiver has hung up, and | ||
| // the receiver should live for as long as Nexus does (it | ||
| // belongs to the background task driver). |
There was a problem hiding this comment.
(This can happen during shutdown, where the order Tokio tasks are torn down in is undefined)
There was a problem hiding this comment.
How about changing it to:
This error can only happen while Nexus's Tokio runtime is shutting down;
Sender::sendreturns an error only if the receiver has hung up, and the receiver should live for as long as Nexus does (it belongs to the background task driver.)In the unlikely event that it does happen within this narrow window, the impact is that the database has recorded a repository for which we no longer have the artifacts. The fix would be to reupload the repository.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #9140.