Skip to content

Conversation

@dependabot
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Apr 14, 2022

Bumps ipnetwork from 0.18.0 to 0.19.0.

Commits
  • 61550ed Merge pull request #149 from achanda/v0.19.0
  • 3503e4c Cut a new release for v0.19.0
  • 9152847 Merge pull request #148 from achanda/remove-html_root_url
  • 501e553 Remove the redundant html_root_url attribute
  • 7120b93 Merge pull request #144 from paolobarbolini/collect-str
  • a57afd9 Remove useless allocation when serializing
  • 8ad4354 Merge pull request #143 from achanda/upgrade-edition
  • 9651b3b feat: Upgrade rust edition
  • 5764406 Merge pull request #142 from achanda/dependabot/add-v2-config-file
  • 4cbd1f2 Upgrade to GitHub-native Dependabot
  • Additional commits viewable in compare view

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

@dependabot dependabot bot added the dependencies Pull requests that update a dependency file label Apr 14, 2022
@davepacheco
Copy link
Collaborator

It seems like this one requires some Diesel work or something? The errors are things like this:
https://github.com/oxidecomputer/omicron/runs/6030531817?check_suite_focus=true#step:11:1939

error[E0277]: the trait bound `IpNetwork: diesel::Expression` is not satisfied
   --> nexus/src/db/model.rs:622:21
    |
622 | #[derive(Queryable, Insertable, Debug, Clone, Selectable, Asset)]
    |                     ^^^^^^^^^^ the trait `diesel::Expression` is not implemented for `IpNetwork`
    |
    = note: required because of the requirements on the impl of `AsExpression<diesel::sql_types::Inet>` for `IpNetwork`
    = note: this error originates in the derive macro `Insertable` (in Nightly builds, run with -Z macro-backtrace for more info)

See also #877.

@dependabot dependabot bot force-pushed the dependabot/cargo/ipnetwork-0.19.0 branch 4 times, most recently from f91501c to aff95fc Compare April 21, 2022 12:56
@dependabot dependabot bot force-pushed the dependabot/cargo/ipnetwork-0.19.0 branch from aff95fc to 394d940 Compare April 25, 2022 19:05
@dependabot dependabot bot force-pushed the dependabot/cargo/ipnetwork-0.19.0 branch from 394d940 to 1d8f3bc Compare May 3, 2022 15:04
@bnaecker
Copy link
Collaborator

bnaecker commented May 3, 2022

This appears to be due to the fact that the current version of diesel, v2.0.0-rc.0, uses ipnetwork=0.18.0. Upgrading the Nexus version to 0.19.0 won't work since traits like diesel::Expression are implemented for types from the older version of the ipnetwork crate.

@davepacheco
Copy link
Collaborator

Thanks @bnaecker. @smklein should we just wait on this PR until diesel updates to 0.19 as well?

I wonder why they're pinned to exactly 0.18 anyway.

@dependabot dependabot bot force-pushed the dependabot/cargo/ipnetwork-0.19.0 branch 3 times, most recently from 28b1768 to 443a39d Compare May 9, 2022 17:33
@dependabot dependabot bot force-pushed the dependabot/cargo/ipnetwork-0.19.0 branch 5 times, most recently from 5b3cf21 to 7d0cbf0 Compare May 20, 2022 19:26
@ahl
Copy link
Contributor

ahl commented May 21, 2022

I think we're blocked on this: diesel-rs/diesel#3178

@dependabot dependabot bot force-pushed the dependabot/cargo/ipnetwork-0.19.0 branch 2 times, most recently from 51cd18f to 71964e3 Compare June 13, 2022 17:06
@dependabot dependabot bot force-pushed the dependabot/cargo/ipnetwork-0.19.0 branch 3 times, most recently from c5d8fcc to 3e6a08c Compare June 26, 2022 02:05
Bumps [ipnetwork](https://github.com/achanda/ipnetwork) from 0.18.0 to 0.19.0.
- [Release notes](https://github.com/achanda/ipnetwork/releases)
- [Commits](achanda/ipnetwork@v0.18.0...v0.19.0)

---
updated-dependencies:
- dependency-name: ipnetwork
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot bot force-pushed the dependabot/cargo/ipnetwork-0.19.0 branch from 3e6a08c to e61d162 Compare June 30, 2022 05:40
@dependabot @github
Copy link
Contributor Author

dependabot bot commented on behalf of github Jul 4, 2022

Superseded by #1351.

@dependabot dependabot bot closed this Jul 4, 2022
@dependabot dependabot bot deleted the dependabot/cargo/ipnetwork-0.19.0 branch July 4, 2022 00:32
leftwo pushed a commit that referenced this pull request Oct 4, 2023
Crucible updates
    all Crucible connections should set TCP_NODELAY (#983)
    Use a fixed size for tag and nonce (#957)
    Log crucible opts on start, order crutest options (#974)
    Lock the Downstairs less (#966)
    Cache dirty flag locally, reducing SQLite operations (#970)
    Make stats mutex synchronous (#961)
    Optimize requeue during flow control conditions (#962)
    Update Rust crate base64 to 0.21.4 (#950)
    Do less in control (#949)
    Fix --flush-per-blocks (#959)
    Fast dependency checking (#916)
    Update actions/checkout action to v4 (#960)
    Use `cargo hakari` for better workspace deps (#956)
    Update actions/checkout digest to 8ade135 (#939)
    Cache block size in Guest (#947)
    Update Rust crate ringbuffer to 0.15.0 (#954)
    Update Rust crate toml to 0.8 (#955)
    Update Rust crate reedline to 0.24.0 (#953)
    Update Rust crate libc to 0.2.148 (#952)
    Update Rust crate indicatif to 0.17.7 (#951)
    Remove unused async (#943)
    Use a synchronous mutex for bw/iop_tokens (#946)
    Make flush ID non-locking (#945)
    Use `oneshot` channels instead of `mpsc` for notification (#918)
    Use a strong type for upstairs negotiation (#941)
    Add a "dynamometer" option to crucible-downstairs (#931)
    Get new work and active count in one lock (#938)
    A bunch of misc test cleanup stuff (#937)
    Wait for a snapshot to finish on all downstairs (#920)
    dsc and clippy cleanup. (#935)
    No need to sort ackable_work (#934)
    Use a strong type for repair ID (#928)
    Keep new jobs sorted (#929)
    Remove state_count function on Downstairs (#927)
    Small cleanup to IOStateCount (#932)
    let cmon and IOStateCount use ClientId (#930)
    Fast return for zero length IOs (#926)
    Use a strong type for client ID (#925)
    A few Crucible Agent fixes (#922)
    Use a newtype for `JobId` (#919)
    Don't pass MutexGuard into functions (#917)
    Crutest updates, rename tests, new options (#911)

Propolis updates
    Update tungstenite crates to 0.20
    Use `strum` crate for enum-related utilities
    Wire up bits for CPUID customization
    PHD: improve artifact store (#529)
    Revert abort-on-panic in 'dev' cargo profile
leftwo added a commit that referenced this pull request Oct 5, 2023
Crucible updates
    all Crucible connections should set TCP_NODELAY (#983)
    Use a fixed size for tag and nonce (#957)
    Log crucible opts on start, order crutest options (#974)
    Lock the Downstairs less (#966)
    Cache dirty flag locally, reducing SQLite operations (#970)
    Make stats mutex synchronous (#961)
    Optimize requeue during flow control conditions (#962)
    Update Rust crate base64 to 0.21.4 (#950)
    Do less in control (#949)
    Fix --flush-per-blocks (#959)
    Fast dependency checking (#916)
    Update actions/checkout action to v4 (#960)
    Use `cargo hakari` for better workspace deps (#956)
    Update actions/checkout digest to 8ade135 (#939)
    Cache block size in Guest (#947)
    Update Rust crate ringbuffer to 0.15.0 (#954)
    Update Rust crate toml to 0.8 (#955)
    Update Rust crate reedline to 0.24.0 (#953)
    Update Rust crate libc to 0.2.148 (#952)
    Update Rust crate indicatif to 0.17.7 (#951)
    Remove unused async (#943)
    Use a synchronous mutex for bw/iop_tokens (#946)
    Make flush ID non-locking (#945)
    Use `oneshot` channels instead of `mpsc` for notification (#918)
    Use a strong type for upstairs negotiation (#941)
    Add a "dynamometer" option to crucible-downstairs (#931)
    Get new work and active count in one lock (#938)
    A bunch of misc test cleanup stuff (#937)
    Wait for a snapshot to finish on all downstairs (#920)
    dsc and clippy cleanup. (#935)
    No need to sort ackable_work (#934)
    Use a strong type for repair ID (#928)
    Keep new jobs sorted (#929)
    Remove state_count function on Downstairs (#927)
    Small cleanup to IOStateCount (#932)
    let cmon and IOStateCount use ClientId (#930)
    Fast return for zero length IOs (#926)
    Use a strong type for client ID (#925)
    A few Crucible Agent fixes (#922)
    Use a newtype for `JobId` (#919)
    Don't pass MutexGuard into functions (#917)
    Crutest updates, rename tests, new options (#911)

Propolis updates
    Update tungstenite crates to 0.20
    Use `strum` crate for enum-related utilities
    Wire up bits for CPUID customization
    PHD: improve artifact store (#529)
    Revert abort-on-panic in 'dev' cargo profile

---------

Co-authored-by: Alan Hanson <alan@oxide.computer>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies Pull requests that update a dependency file

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants