Skip to content

Apply optimal drive settings for Ultrastar DC SN681 #9263

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Oct 23, 2025
Merged

Apply optimal drive settings for Ultrastar DC SN681 #9263

merged 3 commits into from
Oct 23, 2025

Conversation

@papertigers
Copy link
Contributor

@papertigers papertigers commented Oct 20, 2025 •
edited
Loading

This adds the SDS6BA138PSP9X3 nvme drive to sled-agent's
PREFERRED_NVME_DEVICE_SETTINGS hash map, additionally it shuffles some
logic around to always apply a 4K LBA data size to all devices as Robert
suggested in #8867

Fixes #8867

@papertigers
[jj-spr] initial version
64103ed 
Created using jj-spr 1.3.6-beta.1
@papertigers
only apply settings if we are running on an oxide sled
599d43c 
Created using jj-spr 1.3.6-beta.1
@papertigers papertigers requested a review from citrus-it October 20, 2025 20:04
citrus-it
citrus-it approved these changes Oct 21, 2025
View reviewed changes
Copy link
Contributor

@citrus-it citrus-it left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for restructuring and always attempting to find a 4kn namespace format.

@papertigers papertigers requested a review from citrus-it October 23, 2025 00:59
@papertigers
Copy link
Contributor Author

@citrus-it I added the is_oxide_sled() check like we discussed over chat if you could have a look again. Also cleaned up an unwrap while I was in the code.

citrus-it
citrus-it reviewed Oct 23, 2025
View reviewed changes
Copy link
Contributor

@citrus-it citrus-it left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, looks good. Just spotted one typo in a comment.

@papertigers @citrus-it
fix typo
d79cadb 
Co-authored-by: Andy Fiddaman <andy@oxidecomputer.com>
@papertigers papertigers enabled auto-merge (squash) October 23, 2025 16:42
@papertigers papertigers merged commit 84c3410 into main Oct 23, 2025
16 checks passed
@papertigers papertigers deleted the spr/papertigers/apply-optimal-drive-settings-for-ultrastar-dc-sn681 branch October 23, 2025 18:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@citrus-it citrus-it citrus-it approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Apply optimal drive settings for new drives

2 participants

@papertigers @citrus-it