Skip to content

Conversation

@bnaecker
Copy link
Collaborator

@bnaecker bnaecker commented Nov 5, 2025

- Add a where-clause to ensure we skip IP Pool Ranges which have been
  exhausted when searching for the next external IP address.
- Add regressions
- Fixes #9342
@bnaecker bnaecker enabled auto-merge (squash) November 5, 2025 16:55
@david-crespo
Copy link
Contributor

david-crespo commented Nov 5, 2025

One test failure due to the internal error message changing:

thread 'db::queries::external_ip::tests::test_ephemeral_and_snat_ips_do_not_overlap' panicked at nexus/db-queries/src/db/queries/external_ip.rs:1129:9:
  assertion `left == right` failed
    left:  InsufficientCapacity { message: MessagePair { external_message: "No external IP addresses available", internal_context: "NextExternalIp::new returned NotFound" } }
    right: InsufficientCapacity { message: MessagePair { external_message: "No external IP addresses available", internal_context: "NextExternalIp::new tried to insert NULL ip" } }

@bnaecker bnaecker merged commit 92669b0 into main Nov 5, 2025
16 checks passed
@bnaecker bnaecker deleted the search-all-ip-ranges branch November 5, 2025 20:47
iliana pushed a commit that referenced this pull request Nov 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Insufficient external IP address declared prematurely

4 participants