Skip to content

Conversation

@jgallagher
Copy link
Contributor

SledEditor was storing each sled's baseboard ID, but:

  • it's only available via PlanningInput, and putting it directly into the blueprint is difficult for mostly-irrelevant reasons
  • there was only one caller of SledEditor::baseboard_id(): sled_ensure_mupdate_override() (to match up sled ID <-> baseboard ID)
  • sled_ensure_mupdate_override() itself only has one caller, the planner, which already knows the baseboard ID of the sled it's ensuring

So this PR removes SledEditor::baseboard_id() entirely, and has the planner pass the baseboard ID in. (On the update watercooler today we also mentioned the possibility of a separate BlueprintBuilder::clear_pending_mgs_updates(baseboard_id) method, but that's tricky to implement because some nontrivial logic for "should we clear pending MGS updates" is nested inside SledEditor itself.)

Copy link
Contributor

@sunshowers sunshowers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice!

@jgallagher jgallagher merged commit ca96cf3 into main Nov 14, 2025
16 checks passed
@jgallagher jgallagher deleted the john/blueprint-builder-no-baseboard branch November 14, 2025 21:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants