BlueprintBuilder: remove SledEditor::baseboard_id() #9405
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SledEditorwas storing each sled's baseboard ID, but:PlanningInput, and putting it directly into the blueprint is difficult for mostly-irrelevant reasonsSledEditor::baseboard_id():sled_ensure_mupdate_override()(to match up sled ID <-> baseboard ID)sled_ensure_mupdate_override()itself only has one caller, the planner, which already knows the baseboard ID of the sled it's ensuringSo this PR removes
SledEditor::baseboard_id()entirely, and has the planner pass the baseboard ID in. (On the update watercooler today we also mentioned the possibility of a separateBlueprintBuilder::clear_pending_mgs_updates(baseboard_id)method, but that's tricky to implement because some nontrivial logic for "should we clear pending MGS updates" is nested insideSledEditoritself.)