Skip to content

[github actions] No more skipping workflows #948

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 19, 2022
Merged

[github actions] No more skipping workflows #948

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
bdb4a7c
No more skipping duplicate workflows
smklein Apr 19, 2022
26332fb
Merge branch 'main' into no-more-skipping
smklein Apr 19, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 0 additions & 22 deletions .github/workflows/rust.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,21 +6,7 @@ name: Rust
on: [ push, pull_request ]

jobs:
skip_duplicate_jobs:
runs-on: ubuntu-18.04
outputs:
should_skip: ${{ steps.skip_check.outputs.should_skip }}
steps:
- id: skip_check
# fkirc/skip-duplicate-actions@v3.4.0 (plus a bit)
uses: fkirc/skip-duplicate-actions@f75dd6564bb646f95277dc8c3b80612e46a4a1ea
with:
# For workflows which are triggered concurrently with the same
# contents, attempt to execute them exactly once.
concurrent_skipping: 'same_content_newer'
check-style:
needs: skip_duplicate_jobs
if: ${{ needs.skip_duplicate_jobs.outputs.should_skip != 'true' }}
runs-on: ubuntu-18.04
steps:
# actions/checkout@v2
Expand All @@ -33,8 +19,6 @@ jobs:
run: cargo fmt -- --check

check-omicron-deployment:
needs: skip_duplicate_jobs
if: ${{ needs.skip_duplicate_jobs.outputs.should_skip != 'true' }}
runs-on: ${{ matrix.os }}
strategy:
fail-fast: false
Expand All @@ -51,8 +35,6 @@ jobs:
run: cargo run --bin omicron-package -- check

clippy-lint:
needs: skip_duplicate_jobs
if: ${{ needs.skip_duplicate_jobs.outputs.should_skip != 'true' }}
runs-on: ubuntu-18.04
steps:
# actions/checkout@v2
Expand All @@ -74,8 +56,6 @@ jobs:
# This is just a test build of docs. Publicly available docs are built via
# the separate "rustdocs" repo.
build-docs:
needs: skip_duplicate_jobs
if: ${{ needs.skip_duplicate_jobs.outputs.should_skip != 'true' }}
runs-on: ubuntu-18.04
steps:
# actions/checkout@v2
Expand All @@ -90,8 +70,6 @@ jobs:
build-and-test:
env:
OMICRON_TMP: /tmp/omicron_tmp
needs: skip_duplicate_jobs
if: ${{ needs.skip_duplicate_jobs.outputs.should_skip != 'true' }}
runs-on: ${{ matrix.os }}
strategy:
fail-fast: false
Expand Down