Serialize entire SledAgentRequest instead of just subnet
#989
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This pairs with the deserialize call in `Agent::new()` which expects to deserialize the full struct.
smklein
approved these changes
Apr 28, 2022
Collaborator
smklein
left a comment
smklein
left a comment
There was a problem hiding this comment.
Thanks for the fix!
(I do think the "SledAgentRequest" is currently just the subnet, but obviously we need to match what we serialize/deserialize)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pairs with the deserialize call in
Agent::new()which expects to deserialize the full struct.I had a (somewhat) functional sled-agent running, and when restarting the
sled-agentservice, it failed to restart with this error:#967 improves this error message significantly (including adding the filename -
/var/oxide/subnet.tomlin this case), and this change fixes the underlying cause.