-
Notifications
You must be signed in to change notification settings - Fork 63
Support for SAML as a Silo IdP, part 1 #994
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
365050a
81dd77f
13b091d
1e87918
6be4f9f
ed33499
f55fada
ffc9f96
7595933
2566741
b578a99
463b1b6
99bcf08
a12939b
3ec5827
3eb6e98
115ffdd
3f8727a
6fbfec7
c2a8633
531c39f
f92964f
a93ed10
eb0ed4b
4cd4c55
2ef7da6
e77353c
b304994
0afecd6
0bf0847
2e35e06
7c1fbe4
044c82d
d835c45
8a6f954
b083fe5
8571681
1ed412e
74521e8
813876a
56320f3
6597d67
c9d369c
36d3588
5f352d0
fa10a10
9593b8f
378b2c1
dab03ea
46de770
6c42a7c
3393799
2f45e1a
fc0522d
302f878
140f697
f9e2011
609a7e1
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -31,6 +31,10 @@ jobs: | |
| if: ${{ github.ref != 'refs/heads/main' }} | ||
| - name: Report cargo version | ||
| run: cargo --version | ||
| - name: Update PATH | ||
|
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Was this just missed in #870? Or does this change cause this to be needed where it wasn't before?
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. The prereq install definitely is, but I'm not sure about GITHUB_PATH. I was testing with |
||
| run: echo "$PWD/out/cockroachdb/bin:$PWD/out/clickhouse" >> "$GITHUB_PATH" | ||
| - name: Install Pre-Requisites | ||
| run: ./tools/install_prerequisites.sh -y | ||
| - name: Check build of deployed Omicron packages | ||
| run: cargo run --bin omicron-package -- check | ||
|
|
||
|
|
@@ -45,6 +49,10 @@ jobs: | |
| run: cargo --version | ||
| - name: Report Clippy version | ||
| run: cargo clippy -- --version | ||
| - name: Update PATH | ||
| run: echo "$PWD/out/cockroachdb/bin:$PWD/out/clickhouse" >> "$GITHUB_PATH" | ||
| - name: Install Pre-Requisites | ||
| run: ./tools/install_prerequisites.sh -y | ||
| - name: Run Clippy Lints | ||
| # | ||
| # Clippy's style nits are useful, but not worth keeping in CI. This | ||
|
|
@@ -64,6 +72,10 @@ jobs: | |
| if: ${{ github.ref != 'refs/heads/main' }} | ||
| - name: Report cargo version | ||
| run: cargo --version | ||
| - name: Update PATH | ||
| run: echo "$PWD/out/cockroachdb/bin:$PWD/out/clickhouse" >> "$GITHUB_PATH" | ||
| - name: Install Pre-Requisites | ||
| run: ./tools/install_prerequisites.sh -y | ||
| - name: Test build documentation | ||
| run: cargo doc | ||
|
|
||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't know enough context to review this change.