Skip to content
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
58 commits
Select commit Hold shift + click to select a range
365050a
Support for SAML as a Silo IdP, part 1
jmpesp Apr 29, 2022
81dd77f
use impl_enum_type for SiloIdentityProviderType
jmpesp Apr 29, 2022
13b091d
install libxmlsec1-openssl in Dockerfile
jmpesp Apr 29, 2022
1e87918
impl ToString in the impl_enum_type macro
jmpesp Apr 29, 2022
6be4f9f
xmlsec1 too
jmpesp Apr 29, 2022
ed33499
try installing xmlsec1 in check-omicron-deployment
jmpesp Apr 29, 2022
f55fada
put package installs into install_prerequisites.sh
jmpesp Apr 29, 2022
ffc9f96
Merge remote-tracking branch 'upstream/main' into silo_authn_providers
jmpesp May 2, 2022
7595933
no more full table scans
jmpesp May 3, 2022
2566741
Merge remote-tracking branch 'upstream/main' into silo_authn_providers
jmpesp May 4, 2022
b578a99
install library/libxmlsec1 on helios
jmpesp May 4, 2022
463b1b6
update silo identity provider diesel code
jmpesp May 4, 2022
99bcf08
./tools/install_prerequisites.sh for clippy-lint
jmpesp May 4, 2022
a12939b
update PATH
jmpesp May 4, 2022
3ec5827
install libxmlsec1-dev for pkg-config files
jmpesp May 5, 2022
3eb6e98
Merge remote-tracking branch 'upstream/main' into silo_authn_providers
jmpesp May 5, 2022
115ffdd
fmt
jmpesp May 5, 2022
3f8727a
more prereqs for actions
jmpesp May 5, 2022
6fbfec7
apparently helios needs clang?
jmpesp May 5, 2022
c2a8633
Merge remote-tracking branch 'upstream/main' into silo_authn_providers
jmpesp May 5, 2022
531c39f
bindgen uses libclang
jmpesp May 5, 2022
f92964f
add libxmlsec1-dev, put on separate lines
jmpesp May 5, 2022
a93ed10
expand SAML related acronyms
jmpesp May 5, 2022
eb0ed4b
unpin samael crate
jmpesp May 5, 2022
4cd4c55
cargo.lock update
jmpesp May 5, 2022
2ef7da6
remove redundant index on silo_identity_provider, make delete soft
jmpesp May 6, 2022
e77353c
reorder external-authenticator permission grants together
jmpesp May 6, 2022
b304994
correct primary key columns
jmpesp May 6, 2022
0afecd6
add test_impl_enum_type_to_string
jmpesp May 6, 2022
0bf0847
revert to apt-get
jmpesp May 6, 2022
2e35e06
remove local, ldap provider types
jmpesp May 6, 2022
7c1fbe4
fmt
jmpesp May 6, 2022
044c82d
further remove local and ldap
jmpesp May 6, 2022
d835c45
pool_authorized, plus opctx check for silo create child perm
jmpesp May 6, 2022
8a6f954
ErrorHandler::NotFoundByResource
jmpesp May 6, 2022
b083fe5
change to String::from_utf8_lossy
jmpesp May 6, 2022
8571681
remove local and ldap from dbinit
jmpesp May 6, 2022
1ed412e
fmt
jmpesp May 6, 2022
74521e8
turns out I can add id without test failure...?
jmpesp May 9, 2022
813876a
use ErrorHandler::Conflict
jmpesp May 9, 2022
56320f3
better comment
jmpesp May 9, 2022
6597d67
use lazy_static http server, restore unauthorized_coverage
jmpesp May 9, 2022
c9d369c
properly timeout, and return better error messages for idp urls
jmpesp May 9, 2022
36d3588
saml_identity_provider -> saml_identity_providers
jmpesp May 9, 2022
5f352d0
add view for SiloSamlIdentityProvider
jmpesp May 9, 2022
fa10a10
deserialize_with public cert and private keys
jmpesp May 11, 2022
9593b8f
clippy and fmt
jmpesp May 11, 2022
378b2c1
Add authn::SiloSamlIdentityProvider
jmpesp May 11, 2022
dab03ea
Drop Silo prefix on types
jmpesp May 11, 2022
46de770
add error context with try_into fails
jmpesp May 13, 2022
6c42a7c
typo
jmpesp May 16, 2022
3393799
add regular identity to identity provider
jmpesp May 18, 2022
2f45e1a
add support for listing identity providers
jmpesp May 18, 2022
fc0522d
larger request_body_max_bytes for SAML IdP payload
jmpesp May 19, 2022
302f878
get by with samael patch and "cargo update -p clang-sys" for now
jmpesp May 19, 2022
140f697
uncomment test_listing_identity_providers
jmpesp May 24, 2022
f9e2011
add list_identity_providers permission
jmpesp May 25, 2022
609a7e1
use lazy_static for saml identity provider stuff
jmpesp May 25, 2022
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions .github/buildomat/jobs/build-and-test.sh
Original file line number Diff line number Diff line change
Expand Up @@ -49,6 +49,10 @@ banner build
export RUSTFLAGS="-D warnings"
export RUSTDOCFLAGS="-D warnings"
export TMPDIR=$TEST_TMPDIR

# "bindgen leverages libclang to preprocess, parse, and type check C and C++ header files."
export LIBCLANG_PATH=/opt/ooce/clang-12.0/lib/
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know enough context to review this change.


ptime -m cargo +'nightly-2022-04-27' build --locked --all-targets --verbose

#
Expand Down
12 changes: 12 additions & 0 deletions .github/workflows/rust.yml
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,10 @@ jobs:
if: ${{ github.ref != 'refs/heads/main' }}
- name: Report cargo version
run: cargo --version
- name: Update PATH
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was this just missed in #870? Or does this change cause this to be needed where it wasn't before?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The prereq install definitely is, but I'm not sure about GITHUB_PATH. I was testing with nektos/act and found that it was necessary. I can push a commit to see if it's not.

run: echo "$PWD/out/cockroachdb/bin:$PWD/out/clickhouse" >> "$GITHUB_PATH"
- name: Install Pre-Requisites
run: ./tools/install_prerequisites.sh -y
- name: Check build of deployed Omicron packages
run: cargo run --bin omicron-package -- check

Expand All @@ -45,6 +49,10 @@ jobs:
run: cargo --version
- name: Report Clippy version
run: cargo clippy -- --version
- name: Update PATH
run: echo "$PWD/out/cockroachdb/bin:$PWD/out/clickhouse" >> "$GITHUB_PATH"
- name: Install Pre-Requisites
run: ./tools/install_prerequisites.sh -y
- name: Run Clippy Lints
#
# Clippy's style nits are useful, but not worth keeping in CI. This
Expand All @@ -64,6 +72,10 @@ jobs:
if: ${{ github.ref != 'refs/heads/main' }}
- name: Report cargo version
run: cargo --version
- name: Update PATH
run: echo "$PWD/out/cockroachdb/bin:$PWD/out/clickhouse" >> "$GITHUB_PATH"
- name: Install Pre-Requisites
run: ./tools/install_prerequisites.sh -y
- name: Test build documentation
run: cargo doc

Expand Down
Loading