Skip to content

Handle nullable array items. #341

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 19, 2025
Merged

Handle nullable array items. #341

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 16 additions & 0 deletions internal/generate/utils.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -144,6 +144,22 @@ func convertToValidGoType(property, typeName string, r *openapi3.SchemaRef) stri
}

func schemaValueToGoType(schemaValue *openapi3.Schema, property string) string {
// In the special case of an array of nullable items, we represent the
// item type with an allOf of length 1. In this case, return the schema
// of the 0th entry in anyOf.
if len(schemaValue.AllOf) == 1 {
value := schemaValue.AllOf[0]
reference := getReferenceSchema(value)
if reference == "" {
fmt.Printf("[WARN] TODO: handle allOf %+v for %q, marking as any for now\n", value, property)
return "any"
}
if schemaValue.Nullable {
reference = fmt.Sprintf("*%s", reference)
}
return reference
}

if schemaValue.Type == nil {
fmt.Printf("[WARN] TODO: handle nil type for %q, marking as any for now\n", property)
return "any"
Expand Down
8 changes: 4 additions & 4 deletions oxide/types.go
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.